Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] add step-by-step logging to long migration #3102

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[chore] add step-by-step logging to long migration #3102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/db/bundb/migrations/20240620074530_interaction_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import (
func init() {
up := func(ctx context.Context, db *bun.DB) error {
log.Info(ctx, "migrating statuses and account settings to interaction policy model, please wait...")
log.Warn(ctx, "**WITH A LARGE DATABASE / LOWER SPEC MACHINE, THIS MIGRATION MAY TAKE A VERY LONG TIME (an hour or even longer); DO NOT INTERRUPT IT!**")
return db.RunInTx(ctx, nil, func(ctx context.Context, tx bun.Tx) error {

// Add new columns for interaction
Expand Down Expand Up @@ -134,6 +135,7 @@ func init() {
args = append(args, bun.Safe(spec.defaultVal))
}

log.Infof(ctx, "adding column '%s' to '%s'...", spec.column, spec.table)
if _, err := tx.ExecContext(ctx, qStr, args...); err != nil {
return err
}
Expand All @@ -143,6 +145,7 @@ func init() {
// with non-default old flags set.
oldStatuses := []oldmodel.Status{}

log.Info(ctx, "migrating existing statuses to new visibility model...")
if err := tx.
NewSelect().
Model(&oldStatuses).
Expand Down Expand Up @@ -218,6 +221,7 @@ func init() {
"boostable",
}
for _, column := range oldColumns {
log.Infof(ctx, "dropping now-unused status column '%s'; this may take a while if you have lots of statuses in your database...", column)
if _, err := tx.
NewDropColumn().
Table("statuses").
Expand All @@ -228,6 +232,7 @@ func init() {
}

// Add new indexes.
log.Info(ctx, "adding new index 'statuses_pending_approval_idx' to 'statuses'...")
if _, err := tx.
NewCreateIndex().
Table("statuses").
Expand All @@ -238,6 +243,7 @@ func init() {
return err
}

log.Info(ctx, "adding new index 'status_faves_pending_approval_idx' to 'status_faves'...")
if _, err := tx.
NewCreateIndex().
Table("status_faves").
Expand All @@ -248,6 +254,7 @@ func init() {
return err
}

log.Info(ctx, "committing transaction, almost done...")
return nil
})
}
Expand Down