Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Default to WASM-based SQLite driver #3053

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Conversation

daenney
Copy link
Member

@daenney daenney commented Jun 28, 2024

Description

With 0.16 out this switches our default SQLite driver to the WASM-based solution instead. So far the driver seems to perform just as well. Switching our default should result in it getting a bit more testing during the 0.17 development cycle.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

With 0.16 out this switches our default SQLite driver to the WASM-based
solution instead. So far the driver seems to perform just as well.
Switching our default should result in it getting a bit more testing
during the 0.17 development cycle.
@daenney
Copy link
Member Author

daenney commented Jun 28, 2024

The diff on this is really awkward because Git...

@daenney
Copy link
Member Author

daenney commented Jun 28, 2024

If issues arise we can revert this commit before we cut a 0.17 release candidate.

@daenney
Copy link
Member Author

daenney commented Jun 28, 2024

@tsmethurst I think this requires your intervention because it also changes the Drone file.

@tsmethurst tsmethurst merged commit 137ef5a into main Jun 29, 2024
3 checks passed
@tsmethurst tsmethurst deleted the default-wasm-sqlite branch June 29, 2024 07:35
@tsmethurst
Copy link
Contributor

Kapow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants