[bugfix] Deref stats async, serve stub collections if handshaking #2990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request solves a bug introduced in 0.16.0-rc1 where account stats were fetched during the initial dereference attempt, leading to a potential recursive handshake loop where two GtS instances would fail to dereference each other.
The fix is to:
The PR also stops serving totalItems in cases where the receiving account has decided to hide their collections. This brings it in line with what Mastodon glitch does.
Oh, and the PR also uses our paging code for
outbox
, in contrast to the sorta freewheeling code we had there before.Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.