Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Deref stats async, serve stub collections if handshaking #2990

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

tsmethurst
Copy link
Contributor

@tsmethurst tsmethurst commented Jun 10, 2024

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request solves a bug introduced in 0.16.0-rc1 where account stats were fetched during the initial dereference attempt, leading to a potential recursive handshake loop where two GtS instances would fail to dereference each other.

The fix is to:

  1. Only fetch stats asynchronously, and during a first dereference just return local stats (ie., 0 followers, 0 following, 0 statuses).
  2. Serve bare stub endpoints for an Actor's collections (without even totalItems) if dereference is done during handshaking, just to get things moving along. This part isn't strictly necessary to fix this bug now, but it will ensure that future softwares trying to deref GtS collections, who withhold their collections first, can still get something in response.

The PR also stops serving totalItems in cases where the receiving account has decided to hide their collections. This brings it in line with what Mastodon glitch does.

Oh, and the PR also uses our paging code for outbox, in contrast to the sorta freewheeling code we had there before.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

just a few comments but otherwise looking good! nice work 👌

@tsmethurst tsmethurst merged commit 611f9de into main Jun 11, 2024
3 checks passed
@tsmethurst tsmethurst deleted the deref_stats_fix branch June 11, 2024 09:54
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…perseriousbusiness#2990)

* [bugfix] Deref stats async, allow peek if handshaking

* don't return totalItems when handshaking or hiding collections

* use GetLimit()

* use StubAccountStats
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
…perseriousbusiness#2990)

* [bugfix] Deref stats async, allow peek if handshaking

* don't return totalItems when handshaking or hiding collections

* use GetLimit()

* use StubAccountStats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants