Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix minor API issue w/ boosted statuses #2846

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

Following the Mastodon API we should be taking interaction counts from the boosted status, rather than generating them separately on the boost wrapper status, when serializing via the API.

This PR fixes that by serializing the wrapped reblogged status first, then just taking the interactions from that.

This also means fewer DB calls in total when serializing a boosted status, which is a nice bonus :)

MIGHT be a fix for #2844 but i'm not sure.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@tsmethurst tsmethurst merged commit 8cf685f into main Apr 17, 2024
3 checks passed
@tsmethurst tsmethurst deleted the boosted_status_interactions branch April 17, 2024 10:41
@NyaaaWhatsUpDoc
Copy link
Member

nice! I'm always a fan of fewer db calls 😎

nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
nyarla pushed a commit to nyarla/gotosocial-modded that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants