Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] improved authenticate post inbox error handling #2803

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

updates the failed auth error handling on the post inbox route to better handle returned errors, previously we were masking a lot with just "not authenticated" which wasn't the most useful in the logs :D

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member Author

@daenney have fixed the test now and added some extra code comments explaining the odd ish logic going on

@daenney
Copy link
Member

daenney commented Apr 3, 2024

Awesome. Thanks for adding the comments, that's great!

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 15ede4c into superseriousbusiness:main Apr 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants