[feature] User-selectable preset CSS themes for accounts #2777
Conversation
|
These themes are awesome! 💜 |
|
The one thing I'm wondering is if it would make the implementation simpler if we extracted the current default theme as a "user" theme too, and then in the migration set that value. Then you don't have to deal with things being optional/unset/empty in the DB and the various structs. That may also make it easier for folks who like the official theme but want to tweak it a bit to work from? |
Mmm that would be a very good idea for a future change! It's quite a lot of work unfortunately because the official theme is really a combination of a bunch of the basic stuff, and the colors etc are defined quite high up in the cascade, so pulling them out will be a bit of a headache. In other words, it's something we should do as part of a proper refactor I think. |
|
|
||
| // Convert themes to apimodel. | ||
| themes := make([]apimodel.Theme, len(gtsThemes.SortedByTitle)) | ||
| for i, gtsTheme := range gtsThemes.SortedByTitle { |
There was a problem hiding this comment.
i think it's probably worth moving this to the typeconverter package just for conformity. though probably not something that needs to be a method receiver to the Converter{} type itself, just a regular package function
There was a problem hiding this comment.
and i assume probably worth making the account function instead return api theme models too, just to fit with how a lot of it is already done. what do you think??
There was a problem hiding this comment.
Mmm yes, I will change it!
internal/web/profile.go
Outdated
| @@ -140,16 +140,31 @@ func (m *Module) profileGETHandler(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| // Basic profile stylesheets. | |||
| stylesheets := []string{ | |||
There was a problem hiding this comment.
not that important, but you could preallocate the slice here with stylesheets = make([]string, 5, 6); stylesheets[0] = ...; stylesheets[1] = ...'; etc.
There was a problem hiding this comment.
Mmm I tried and it came out a bit messy, so I compromised by preallocating the total size but still appending. I think that's probably fine for this case :P
internal/web/thread.go
Outdated
| @@ -138,16 +138,31 @@ func (m *Module) threadGETHandler(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| // Basic thread stylesheets. | |||
| stylesheets := []string{ | |||
| cssFA, cssStatus, cssThread, | |||
There was a problem hiding this comment.
same as above (though 4,5)
|
very nice work, excited to try this 👀 |
Description
This pull request adds functionality for user-selectable preset CSS themes, and includes some themes to start with.
Themes are parsed from
web/assets/themeson startup, and pointers to parsed theme info are stored in the accounts processor, retrieved using the new/api/v1/accounts/themesendpoint, and set along with other settings using/api/v1/accounts/update_credentials. Theme CSS files themselves are served from the assets folder along with other assets (and therefore get etag stuff too).Documentation added for how to select a theme, and how to add new themes (for admins).
Some screenshots!
Settings panel:
Dark blurple:
Light blurple:
Midnight trip:
Soft:
Sunset light:
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]->[x]If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...andgolangci-lint run.