Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Downgrade sqlite v1.29.2 -> v1.28.0 #2736

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

tsmethurst
Copy link
Contributor

Description

If this is a code change, please include a summary of what you've coded, and link to the issue(s) it closes/implements.

If this is a documentation change, please briefly describe what you've changed and why.

This pull request just downgrades our sqlite dependency to the latest version that doesn't have the issue described in #2728, so we can take our time to figure out why versions above that cause issues.

Checklist

Please put an x inside each checkbox to indicate that you've read and followed it: [ ] -> [x]

If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member

NyaaaWhatsUpDoc commented Mar 8, 2024

I'm not sure this is needed with the latest change #2731

this downgrade only reduces the chance the Xsqlite_interrupt will be called, if called it will still likely cause the same issue. (also the context handling is better in these minor releases)

while 2731 is a workaround it does rather elegantly solve the situation, and it won't cancel any in-progress queries or anything (as the conns are afaik only meant to be in use with one caller at a time)

from the driver.Conn docs: "Conn is a connection to a database. It is not used concurrently by multiple goroutines."

@tsmethurst tsmethurst changed the title [chore] Downgrade sqlite v1.29.2 -> v1.29.0 [chore] Downgrade sqlite v1.29.2 -> v1.28.0 Mar 8, 2024
@tsmethurst
Copy link
Contributor Author

Context for our viewers at home: after kim's comment we did some investigation in the matrix chat and we figure this is possibly an sqlite regression, so we decided to step all the way back down to v1.28.0 instead of v1.29.0.

@tsmethurst tsmethurst merged commit ebdee5a into main Mar 8, 2024
3 checks passed
@tsmethurst tsmethurst deleted the downgrade_sqlite_to_1_29_0 branch March 8, 2024 10:45
tsmethurst added a commit that referenced this pull request Mar 8, 2024
* [chore] Downgrade sqlite v1.29.2 -> v1.29.0

* go down to v1.28.0
tsmethurst added a commit that referenced this pull request Mar 9, 2024
* [chore] Downgrade sqlite v1.29.2 -> v1.29.0

* go down to v1.28.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants