Improve context descendant sorting #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Topologically sort replies, then move self-replies to top of list
VyrCossont
force-pushed
the
context-descendant-sorting
branch
from
3168804 to
dd0ccc5
Compare
VyrCossont
force-pushed
the
context-descendant-sorting
branch
from
55e6622 to
a951538
Compare
tsmethurst
reviewed
Jan 29, 2024
tsmethurst
reviewed
Jan 29, 2024
|
Looks neat to me :) @NyaaaWhatsUpDoc do you have any comments on the sorting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Topologically sort replies, moving self-replies to top of list. The topo sort is decent at producing runs of reply chains in the output, although it's probably possible to improve on that.
Fixes #2479
Checklist
go fmt ./...golangci-lint run. (for some reason this is incredibly slow on my Mac, like 10 minutes at 800% CPU and it hasn't finished)