-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[performance] overhaul struct (+ result) caching library for simplicity, performance and multiple-result lookups #2535
Conversation
this diff is a lot more intimidating than it looks in terms of actual gotosocial code, because it includes dropping the old result library from vendor/, and adding the new one. the separate library itself can be found at https://codeberg.org/gruf/go-structr |
d8d424c
to
316c578
Compare
the cache size estimator i'm going to do in a separate PR, this PR is already large enough, and enough of the internals are similar that the size estimations won't actually be that far off |
0f4868c
to
4c6dee1
Compare
… add note regarding which caches require start/stop
…ixed up in my head somehow lol)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job kimbe 👍
Description
codeberg.org/gruf/go-structr
instead ofcodeberg.org/gruf/go-cache/v3/result
for result / struct caching which includes the following changes:Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.