-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frogend] (Mastodon) domain block CSV import #1390
Conversation
This looks really good to me :) Just wondering about what we discussed briefly in matrix: domains that are wildcarded by starting with |
hmm I feel like the server should reject them if it doesn't handle it for you, because as a literal * it's never a valid domain. If we don't want to handle them in the backend I can update the client validation to match, and possibly add the trimming there I'm actually not sure if Mastodon even handles those wildcards either.. |
I can add something to trim it in the server side, then it'll work via the API too and not just the settings panel: I needed a small thing to work on this afternoon anyway :) |
commit e3655ba Author: f0x <f0x@cthu.lu> Date: Tue Jan 31 15:19:10 2023 +0100 let debug depend on env (prod/debug) again commit 79c792b Author: f0x <f0x@cthu.lu> Date: Tue Jan 31 00:34:01 2023 +0100 update checklist components commit 4367960 Author: f0x <f0x@cthu.lu> Date: Mon Jan 30 23:46:20 2023 +0100 checklist performance improvements commit 204a4c0 Author: f0x <f0x@cthu.lu> Date: Mon Jan 30 20:05:34 2023 +0100 checklist field: use reducer for state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me so far :)
Description
Adds CSV import and export to the bulk import/export interface, tested to be compatible with Mastodon too (glitch-soc).
Generally cleans up the code structure around it a bit too, both on the page itself and the exportType based branching in query.
Also added some information text about the page, and a table comparing the different export formats. Still not sure how well it fits there, might just have to move that to the docs, or a separate page?
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.