[chore] set max open / idle conns + conn max lifetime for both postgres and sqlite #1369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates some of our database tuning. Previously we were only setting maxopenconns and maxidleconns for postgres, and only setting connmaxlifetime(0) for in-mem sqlite connections, to avoid the db being deleted on connection cleanup.
Now, this tuning has been combined and is done for both database types. This is partially because we should have already been setting maxopenconns and maxidleconns for sqlite but weren't, and also to see if some SQLITE_BUSY errors can be resolved by never letting sqlite connections die (see https://www.sqlite.org/wal.html#sometimes_queries_return_sqlite_busy_in_wal_mode)
The PR also reduces the default cache size for sqlite connections to 8MiB, since 64MiB ended up using rather a lot of memory.
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.