Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Settings refactor fix 2 #1357

Merged
merged 3 commits into from
Jan 18, 2023
Merged

[chore] Settings refactor fix 2 #1357

merged 3 commits into from
Jan 18, 2023

Conversation

f0x52
Copy link
Contributor

@f0x52 f0x52 commented Jan 18, 2023

Three small fixes building on settings-refactor:

  • 'Emoji' RTK Query tag type got lost, re-added and renamed
  • Replace 'localhost' with '127.0.0.1' in webdev setup proxy, because GTS doesn't listen on ::1
  • Fix issue where login flow quickly flashed "expecting callback" error before redirecting to the instance login flow

@f0x52 f0x52 added the frontend Frontend-related stuff label Jan 18, 2023
@f0x52 f0x52 assigned tsmethurst and unassigned tsmethurst Jan 18, 2023
@f0x52 f0x52 requested a review from tsmethurst January 18, 2023 15:39
@tsmethurst
Copy link
Contributor

Feel free to merge if you're happy with it :) I'm out of spoons to review today but I trust ya

@f0x52 f0x52 merged commit 747683b into main Jan 18, 2023
@f0x52 f0x52 deleted the settings-refactor-fix2 branch January 18, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmethurst tsmethurst Awaiting requested review from tsmethurst

Assignees
No one assigned
Labels
frontend Frontend-related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f0x52 @tsmethurst