[chore] Remove omitempty on account source; refactor tests to use prettyprint json #1337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates some of the account serialization logic to remove some omitEmpty annotations that were causing trouble + resulting in missing fields. Tests have been updated for this.
While I was in the code, I also refactored tests elsewhere in the codebase to use prettyprinted json when non-trivial json is being diffed. This lets us more easily see what's failing when tests fail. The actual substance of the tests has not changed at all, it's purely formatting.
closes #1332
Checklist
Please put an x inside each checkbox to indicate that you've read and followed it:
[ ]
->[x]
If this is a documentation change, only the first checkbox must be filled (you can delete the others if you want).
go fmt ./...
andgolangci-lint run
.