[performance]: make s3 urls cacheable #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSuess
force-pushed
the
s3-cacheable
branch
from
80c3055 to
33936a9
Compare
theSuess
commented
Dec 1, 2022
| "codeberg.org/gruf/go-store/v2/kv" | ||
| "codeberg.org/gruf/go-store/v2/storage" | ||
| "github.com/minio/minio-go/v7" | ||
| "github.com/minio/minio-go/v7/pkg/credentials" | ||
| "github.com/superseriousbusiness/gotosocial/internal/config" | ||
| ) | ||
|
|
||
| const ( | ||
| urlCacheTTL = time.Hour * 24 |
There was a problem hiding this comment.
Maybe this should be configurable, but I'm not too sure if it is actually that useful
There was a problem hiding this comment.
We have many configuration options we mean to sort-out in time. We can leave it until then :')
Implements superseriousbusiness#864 and should speed up s3 based installations by a lot. With more static urls, we can then also implement superseriousbusiness#1026 for even better performance when used in conjunction with CDNs
theSuess
force-pushed
the
s3-cacheable
branch
from
33936a9 to
b036e88
Compare
|
this looks OK to me if you're both happy with it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #864 and should speed up s3 based installations by a lot.
With more static URL, we can then also implement #1026 for even better performance when used in conjunction with CDNs
I hope that I used the cache library correctly - oriented myself on the
eTagCache(Also tweaked the testrig to use the actual storage implementation for building the S3 config)