Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] media: add webp support #1155

Merged
merged 2 commits into from
Dec 6, 2022

Conversation

ftrvxmtrx
Copy link
Contributor

@ftrvxmtrx ftrvxmtrx commented Nov 26, 2022

Along with superseriousbusiness/exif-terminator#4 this made me able to find and follow a person on mas.to that had their avatar image in webp format. Otherwise it results in error related to not being able to process webp.
I can update this PR properly once the exif-terminator one is merged.

@ftrvxmtrx ftrvxmtrx marked this pull request as draft November 26, 2022 20:55
@tsmethurst
Copy link
Contributor

Thanks for opening this! I've commented on your PR over on the exif-terminator repo :)

Otherwise it results in error related to not being able to process webp.

Darn! Unrelated to this PR then, but we should also update some of the account dereferencing logic to be able to handle unknown file types on avatars / headers (perhaps just skipping the image if we can't process it). This might also be related to an issue we've been having with Honk federation...

@ftrvxmtrx
Copy link
Contributor Author

@tsmethurst I guess it boils down to the question if it's fine to store (potentially) sensitive data since EXIF won't be stripped out of unsupported media?

@tsmethurst
Copy link
Contributor

Indeed! I'd rather not store the data at all then, if we can't be sure it doesn't contain sensitive information. But I think by just skipping it completely if it's an unknown type, we can avoid this :)

@ftrvxmtrx ftrvxmtrx force-pushed the webp branch 2 times, most recently from 20e54b6 to ce56632 Compare December 4, 2022 21:57
Signed-off-by: Sigrid Solveig Haflínudóttir <sigrid@ftrv.se>
Signed-off-by: Sigrid Solveig Haflínudóttir <sigrid@ftrv.se>
@ftrvxmtrx ftrvxmtrx marked this pull request as ready for review December 4, 2022 22:06
Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! :) Will merge this after cutting 0.6.0

@tsmethurst tsmethurst added the ready Ready to merge when appropriate label Dec 5, 2022
@tsmethurst tsmethurst merged commit 1a3f26f into superseriousbusiness:main Dec 6, 2022
@ftrvxmtrx ftrvxmtrx deleted the webp branch December 6, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready to merge when appropriate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants