[bugfix] Change emailVerified to true for admin account create #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NewSignup method was already being called with requireApproval=false, but it had emailVerified=false as well, which meant that it was required to use the `admin account confirm` command to verify the email before the newly-created user could log in. I think that was probably an oversight; effectively it did require approval anyway. Changing emailVerified to true allows you to just create the account and log in immediately, reducing the opportunity for manual error to sneak in. Also updated the docs to remove the mention of needing to confirm new accounts. However, I've left the confirmation command alone because I think once we have web signups, it will be needed in that context.
|
Looks good, thank you :) |
|
I just realized I may have been a little hasty here; this is going to change the docs at https://docs.gotosocial.org/en/latest/ which means that people installing 0.5.2 will run into a situation where they will need to confirm but the docs don't explain it. So unless we're like ... right on the cusp of releasing 0.6.0, I should probably add a note about the fact that confirm is necessary on some versions and not others. Sorry I missed this earlier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NewSignup method was already being called with requireApproval=false, but it had emailVerified=false as well, which meant that it was necessary to use the
admin account confirmcommand to verify the email before the newly-created user could log in.I think that was probably an oversight; effectively it did require approval anyway. Changing emailVerified to true allows you to just create the account and log in immediately, streamlining the setup and reducing the opportunity for manual error to sneak in.
Also updated the docs to remove the mention of needing to confirm new accounts. However, I've left the confirmation command alone because I think once we have web signups, it will be needed in that context.
It's possible I've overlooked something about the
admin account confirmand it does in fact still make sense even for accounts created thru the CLI; if so please feel free to close this!