-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] move caches to a separate State{} structure #1078
[chore] move caches to a separate State{} structure #1078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it's going in a good direction!
is it worth making state.State into an interface instead of just using the struct, so that in future we can use different kinds of state objects? (just thinking years in the future here, when we start messing about with remote state etc)
d1b379c
to
d0001c3
Compare
95d1431
to
9ed9f31
Compare
@tsmethurst I started to make the I would say this is ready to review now, but getting this 0.6.0 release out is more important first for sure :D |
9ed9f31
to
5210e12
Compare
lmk when you want me to review this again kimbe :) |
5210e12
to
dd75419
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a few comments but nothing significant. This looks really great, and is good to go afaict :) Amazing work kimbe
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
Signed-off-by: kim <grufwub@gmail.com>
7b4fb2b
to
abaa418
Compare
This moves toward consolidating much of our means of dependency injection. It will also make it easier sharing resources across the codebase, and in the particular case of the caches, invalidating the necessary caches on particular changes.