[feature] Serialize local account role via API, and show it via web view #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend changes look good :), my only critique is a UI thing, in that I think we should only display non-default roles. i.e. most users' profile pages appear as they do currently (pre-PR), but only moderators and admins get a role tag on their profile. |
good idea... will change it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local account roles will be one of
user,moderator, oradmin. For remote accounts,rolewill not be serialized in the json.The role of an account will now be shown on the web view of that account's profile (see screenshots below).
I don't think this will trip up clients that use the Mastodon API, but we'll have to see. We might need to make this a config option for optimum masto API compatibility, but I hope not.
Closes #814
Closes #815