Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add instance-expose-public-timeline flag #1039

Merged

Conversation

sargant
Copy link
Contributor

@sargant sargant commented Nov 12, 2022

Adds a config flag that allows unauthenticated access to /api/v1/timelines/public. Defaults to false to replicate existing behaviour.

Implements #1031

(Also first ever time writing Go! Sorry for being part of the Eternal September...)

Adds a config flag that allows unauthenticated access to /api/v1/timelines/public. Defaults to false to replicate existing behaviour.
@sargant sargant changed the title Add instance-expose-public-timeline flag [feature] add instance-expose-public-timeline flag Nov 13, 2022
@tsmethurst
Copy link
Contributor

Sorry for being part of the Eternal September

I keep seeing that phrase but I have no idea what it means :') The pull request is much appreciated! Will review it shortly :)

@sargant
Copy link
Contributor Author

sargant commented Nov 13, 2022

Sorry for being part of the Eternal September

I keep seeing that phrase but I have no idea what it means :')

Back in the very early days of the internet, people only got access to Usenet discussions when they started university in September, so there was a sudden downtick in etiquette, then people got better behaved. Then AOL gave all its users access to Usenet, and there were people new to the system all the time, and the need for constant moderation began ;)

https://en.wikipedia.org/wiki/Eternal_September#History

The same thing is happening with ActivityPub/Mastodon now with the exodus from the "other place", and I'm part of that exodus - sorry!

Copy link
Contributor

@tsmethurst tsmethurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :) Just the change I recommended in the comment. @NyaaaWhatsUpDoc do you have any thoughts on this PR overall?

internal/api/client/timeline/public.go Outdated Show resolved Hide resolved
@tsmethurst tsmethurst merged commit d120743 into superseriousbusiness:main Nov 14, 2022
@tsmethurst
Copy link
Contributor

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants