Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Implement "api/v1/notifications?limit=20&types[]=mention" #3003

Closed
Fastidious opened this issue Jun 12, 2024 · 2 comments · Fixed by #3009
Closed

[feature] Implement "api/v1/notifications?limit=20&types[]=mention" #3003

Fastidious opened this issue Jun 12, 2024 · 2 comments · Fixed by #3009
Labels
enhancement New feature or request
Milestone

Comments

@Fastidious
Copy link

Fastidious commented Jun 12, 2024

Is your feature request related to a problem ?

Yes, and no. Yes, because it doesn't work and renders an error on Phanpy (or any client that uses the same API filter), no, because it isn't a show stopper.

Phanpy, a favourite of many Mastodon client, allows for the filtering of mentions using api/v1/notifications?limit=20&types[]=mention, using the notifications API. When connected to GoToSocial such feature doesn't work (see cheeaun/phanpy#567).

Describe the solution you'd like.

Based on the above, could it be possible to implement the API to allow filtering on notifications?

Describe alternatives you've considered.

NONE

Additional context.

No response

@Fastidious Fastidious added the enhancement New feature or request label Jun 12, 2024
@tsmethurst tsmethurst modified the milestone: v0.17.0 Jun 13, 2024
VyrCossont added a commit to VyrCossont/gotosocial that referenced this issue Jun 14, 2024
Counterpart of exclude_types[].

Also updates Swagger spec for types[] to use the correct param name and enumerate possible values.

Fixes superseriousbusiness#3003
@Fastidious
Copy link
Author

Just got the snapshot (b08c1bd) to test this one, and I am getting the same error on Phanpy. Is there something I need to set on config?

@tsmethurst
Copy link
Contributor

#3023 will resolve remaining bug

VyrCossont added a commit to VyrCossont/gotosocial that referenced this issue Jun 19, 2024
…ness#3009)

Counterpart of exclude_types[].

Also updates Swagger spec for types[] to use the correct param name and enumerate possible values.

Fixes superseriousbusiness#3003

(cherry picked from commit b08c1bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants