Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing an un-parsable regex expression into the settings search window causes SS to crash #3776

Closed
Cisien opened this issue Apr 3, 2023 · 0 comments
Closed

Typing an un-parsable regex expression into the settings search window causes SS to crash #3776

Cisien opened this issue Apr 3, 2023 · 0 comments
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.

Comments

@Cisien
Copy link

Cisien commented Apr 3, 2023

What happened?

The crash details only contain the following:
14:58:49: Internal error: regex_error(error_brack): The expression contained mismatched [ and ].
14:58:49: Internal error: regex_error(error_brack): The expression contained mismatched [ and ].
14:58:49: Internal error: regex_error(error_brack): The expression contained mismatched [ and ].
14:58:49: Internal error: regex_error(error_brack): The expression contained mismatched [ and ].
image

Project file & How to reproduce

This can be reproduced by navigating to the Print Settings tab, hitting Ctrl + F or clicking on the search button, and typing [ or ] into the settings search window

Version

2.4.x, 2.5.59.2

Operating system

Windows 11

Printer model

Voron 2.4
@supermerill supermerill added bug Something isn't working as intended fixed for the next version That means that you should be able to test it in the latest nightly build labels Nov 22, 2023
supermerill added a commit that referenced this issue Nov 22, 2023
@supermerill
Fix search with regexp
99c8a04 
#3776
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Cisien @supermerill