Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wipe tower brim width incorrectly calculated #3031

Closed
Pavulon87 opened this issue Aug 5, 2022 · 2 comments
Closed

Wipe tower brim width incorrectly calculated #3031

Pavulon87 opened this issue Aug 5, 2022 · 2 comments
Labels
bug Something isn't working as intended fixed for the next version That means that you should be able to test it in the latest nightly build

Comments

@Pavulon87
Copy link

What happened?

Previous versions of SuSi had the default value of 150% and everything was fine(now it is 2mm).
But in latest build something is wrong in calculation algorithm and brim could be bigger than a build plate when using percentage value.

150%
brim150

15%
brim15

Project file & How to reproduce

Shape-Box.zip

Version

2.4.58.3 / 2.5.59.0

Operating system

windows 10

Printer model

not relevant

@Pavulon87
Copy link
Author

Pavulon87 commented Aug 5, 2022

I'm not sure, but maybe the point is that percentages are used as mm?

m_wipe_tower_brim_width(float(config.wipe_tower_brim_width)),
(...)
size_t loops_num = (m_wipe_tower_brim_width + spacing / 2) / spacing;

Previously:
double unscaled_brim_width = m_config->wipe_tower_brim.get_abs_value(m_nozzle_diameter);

Edit:
It seems the percentages are ignored.
150% == 150mm

@supermerill
Copy link
Owner

Correct. Maybe another merge quirk.
Merged for next nightly

@supermerill supermerill added bug Something isn't working as intended fixed for the next version That means that you should be able to test it in the latest nightly build labels Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended fixed for the next version That means that you should be able to test it in the latest nightly build
Projects
None yet
Development

No branches or pull requests

2 participants