Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many M73 codes generated [Beta 2.4.58.0] #2380

Closed
javales74 opened this issue Feb 14, 2022 · 2 comments
Closed

Too many M73 codes generated [Beta 2.4.58.0] #2380

javales74 opened this issue Feb 14, 2022 · 2 comments
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce. nightly / dev branch

Comments

@javales74
Copy link

In the 2.4.58.0 Beta version too many M73 codes are generated and oversize the resultating file.
One M73 after every movement.

Sorry if my english is bad.
@supermerill supermerill added bug Something isn't working as intended nightly / dev branch labels Feb 14, 2022
@matthewlloyd
Copy link

matthewlloyd commented Feb 14, 2022 •
edited
Loading

I have a fix for this, and a related bug where the first and last M73 are swapped (first "M73 P100 R0" and last is "M73 P0 R<>"). Testing now and will open a PR in the next hour or so.

matthewlloyd added a commit to matthewlloyd/SuperSlicer that referenced this issue Feb 14, 2022
@matthewlloyd
Fix generation of M73 and M117
60f3488 
* Output only when the progress changes rather than every move.
* First and last M73s were swapped, "M73 P100 R0" and "M73 P0 R<>".
* machine_TO_last_* arrays were uninitialized.

Issue: supermerill#2380
@matthewlloyd matthewlloyd mentioned this issue Feb 14, 2022
Closed
@supermerill
Copy link
Owner

merged

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Mar 11, 2022
supermerill pushed a commit that referenced this issue Mar 11, 2022
@matthewlloyd @supermerill
Fix generation of M73 and M117
d9e991e 
* Output only when the progress changes rather than every move.
* First and last M73s were swapped, "M73 P100 R0" and "M73 P0 R<>".
* machine_TO_last_* arrays were uninitialized.

Issue: #2380
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce. nightly / dev branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matthewlloyd @supermerill @javales74