Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last linux version can't save modification , only cancel buton #2347

Closed
salocain opened this issue Feb 10, 2022 · 3 comments
Closed

last linux version can't save modification , only cancel buton #2347

salocain opened this issue Feb 10, 2022 · 3 comments
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce. nightly / dev branch

Comments

@salocain
Copy link

after my last post i start superslicer from scratch

i configure the software and when i want to quit --> he ask for unsaved config but only cancel buton

only solution --> do a save on each parametre

Capture d’écran du 2022-02-10 18-26-30

@salocain
Copy link
Author

after my last post i start superslicer from scratch

i configure the software and when i want to quit --> he ask for unsaved config but only cancel buton

only solution --> do a save on each parametre

Capture d’écran du 2022-02-10 18-26-30

another bug in remote printer config
for select klipper machine we must select mcvd2 --> the scroll list is decaled
Capture d’écran du 2022-02-10 19-27-33
Capture d’écran du 2022-02-10 19-27-20

@supermerill supermerill added this to the after 2.4 merge milestone Feb 10, 2022
@TomPcz
Copy link

TomPcz commented Feb 14, 2022

This happens also when switching profiles. There is only Transfer and Cancel. Discard and Save buttons are missing.
Screenshot_20220214_134645

@supermerill supermerill added bug Something isn't working as intended nightly / dev branch labels Feb 14, 2022
@TomPcz
Copy link

TomPcz commented Feb 15, 2022

Here is where the buttons are disabled if __WXGTK__ is defined. I suppose only the cancel button should change based on the condition.

#ifdef __WXGTK__
ScalableButton* cancel_btn = new ScalableButton(this, wxID_ANY, "cross", _L("Cancel"), wxDefaultSize, wxDefaultPosition, wxBORDER_DEFAULT, true, 24);
#else
{ // "Don't save" / "Discard" button
std::string btn_icon = (ActionButtons::DONT_SAVE & m_buttons) ? "" : (dependent_presets || (ActionButtons::KEEP & m_buttons)) ? "switch_presets" : "exit";
wxString btn_label = (ActionButtons::DONT_SAVE & m_buttons) ? _L("Don't save") : _L("Discard");
add_btn(&m_discard_btn, m_continue_btn_id, btn_icon, Action::Discard, btn_label, false);
}
// "Save" button
if (ActionButtons::SAVE & m_buttons)
add_btn(&m_save_btn, m_save_btn_id, "save", Action::Save, _L("Save"));
ScalableButton* cancel_btn = new ScalableButton(this, wxID_CANCEL, "cross", _L("Cancel"), wxDefaultSize, wxDefaultPosition, wxBORDER_DEFAULT, true, 24);
#endif

@supermerill supermerill added the fixed for the next version That means that you should be able to test it in the latest nightly build label Feb 16, 2022
@supermerill supermerill added fix is live in the last release Please download /build the last release and try to reproduce. and removed fixed for the next version That means that you should be able to test it in the latest nightly build labels Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended fix is live in the last release Please download /build the last release and try to reproduce. nightly / dev branch
Projects
None yet
Development

No branches or pull requests

3 participants