-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: replace Jupyter Lab with VS Code notebook support #216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JWuzyk, thanks for this PR! I agree we can improve the experience here. In its current state, isn't this PR more or less equivalent with enabling the with_jupyter_lab
option?
I would prefer to integrate this in the existing Jupyter feature, or replace the existing Jupyter feature entirely, or remove the existing Jupyter feature entirely.
The replacement option could look something like this:
- change the
with_jupyter_lab
feature towith_jupyter
- replace
jupyterlab
withipykernel
- possibly have this new feature enabled by default
The removal option would mean that we keep this PR's changes and remove all with_jupyter_lab
blocks.
BREAKING CHANGE: jupyter_lab option no longer supported
@JWuzyk could you also apply this trick/workaround to automatically select the right kernel in the "jupyter.kernels.excludePythonEnvironments": ["/usr/local/bin/python"] We should probably log this as an issue to improve once the Jupyter extension allows you to configure a default kernel explicitly. |
Added to the PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice improvement to me! Do you want to check with anybody else before we merge this?
The only thing I would add is that these changes are VS Code-centric, people using other IDEs or the CLI will have to install JupyterLab themselves. But I think that's OK so all good for me 🙂 |
You can merge |
Merged! And renamed as the scope changed slightly. |
Improves the experience of using notebooks in VSCode by performing the required setup tasks by default:
ms-toolsai.jupyter
extension.ipykernel
package as a dev dependency.