Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: replace Jupyter Lab with VS Code notebook support #216

Merged
merged 6 commits into from
Feb 28, 2024

Conversation

JWuzyk
Copy link
Collaborator

@JWuzyk JWuzyk commented Feb 22, 2024

Improves the experience of using notebooks in VSCode by performing the required setup tasks by default:

  • Including the ms-toolsai.jupyter extension.
  • Including the ipykernel package as a dev dependency.

@JWuzyk JWuzyk requested a review from lsorber February 22, 2024 10:15
@sinopeus sinopeus self-requested a review February 22, 2024 12:37
Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JWuzyk, thanks for this PR! I agree we can improve the experience here. In its current state, isn't this PR more or less equivalent with enabling the with_jupyter_lab option?

I would prefer to integrate this in the existing Jupyter feature, or replace the existing Jupyter feature entirely, or remove the existing Jupyter feature entirely.

The replacement option could look something like this:

  • change the with_jupyter_lab feature to with_jupyter
  • replace jupyterlab with ipykernel
  • possibly have this new feature enabled by default

The removal option would mean that we keep this PR's changes and remove all with_jupyter_lab blocks.

BREAKING CHANGE: jupyter_lab option no longer supported
@lsorber
Copy link
Member

lsorber commented Feb 25, 2024

@JWuzyk could you also apply this trick/workaround to automatically select the right kernel in the "settings" section in devcontainer.json:

"jupyter.kernels.excludePythonEnvironments": ["/usr/local/bin/python"]

We should probably log this as an issue to improve once the Jupyter extension allows you to configure a default kernel explicitly.

@JWuzyk
Copy link
Collaborator Author

JWuzyk commented Feb 28, 2024

Added to the PR:

  • Enabled format on save for notebooks by default.
  • Removed with_jupyter_lab option
  • Added work around to automatically select correct kernel

Copy link
Member

@lsorber lsorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice improvement to me! Do you want to check with anybody else before we merge this?

@sinopeus
Copy link
Collaborator

The only thing I would add is that these changes are VS Code-centric, people using other IDEs or the CLI will have to install JupyterLab themselves. But I think that's OK so all good for me 🙂

@JWuzyk
Copy link
Collaborator Author

JWuzyk commented Feb 28, 2024

Looks like a nice improvement to me! Do you want to check with anybody else before we merge this?

You can merge

@lsorber lsorber merged commit de61dbf into main Feb 28, 2024
2 checks passed
@lsorber lsorber deleted the jw-vscode-notebook-support branch February 28, 2024 19:52
@lsorber lsorber changed the title chore: vscode notebook setup feat!: replace Jupyter Lab with VS Code notebook support Feb 28, 2024
@lsorber
Copy link
Member

lsorber commented Feb 28, 2024

Merged! And renamed as the scope changed slightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants