Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make private package repos explicit #211

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Jan 10, 2024

This PR adds two changes:

  1. Makes PyPI the default package source when adding a private package repo. This is needed because Poetry warns that this will no longer be the case in a future release.
  2. Makes the private package repo an explicit source, so that you need to mark your dependency with source = "my-private-package-repo" to install from the private package repo.

@lsorber lsorber requested a review from sinopeus January 10, 2024 13:27
@lsorber lsorber self-assigned this Jan 10, 2024
@lsorber lsorber merged commit c3e5979 into main Feb 10, 2024
2 checks passed
@lsorber lsorber deleted the ls-private-package-repo branch February 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants