Tn fixes #2
Merged
Tn fixes #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compatible versions
lsorber
requested changes
Feb 6, 2022
There was a problem hiding this comment.
Thanks for this PR @tanguyNaets! I've added a few comments, most should be easy to resolve.
...slugify }}/{% if cookiecutter.continuous_integration == "GitLab" %}.gitlab-ci.yml{% endif %}
Outdated
Show resolved
Hide resolved
lsorber
reviewed
Feb 7, 2022
…projects, and dev dependency only for other projects
lsorber
reviewed
Feb 8, 2022
lsorber
reviewed
Feb 8, 2022
...slugify }}/{% if cookiecutter.continuous_integration == "GitLab" %}.gitlab-ci.yml{% endif %}
Outdated
Show resolved
Hide resolved
lsorber
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockerindockerimage in use only has sh installed and it would be more cumbersome to install a bash shell and try to set it as the default shell in the first steps. of the script Also, there are nodockerindockerimages built on top of a base layer with bash as the default shell.