Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: do not rely on sdk being valid in sign process #3290

Merged
merged 3 commits into from
Dec 18, 2024
Merged

feat: do not rely on sdk being valid in sign process #3290

merged 3 commits into from
Dec 18, 2024

Conversation

CedrikNikita
Copy link
Collaborator

fixes #2981

@CedrikNikita CedrikNikita requested a review from peronczyk October 2, 2024 05:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from c8cff0b to 851e8e9 Compare October 14, 2024 08:05
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

peronczyk
peronczyk reviewed Oct 16, 2024
View reviewed changes
src/constants/common.ts Outdated Show resolved Hide resolved
@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch 2 times, most recently from c622d37 to 5a9988f Compare October 17, 2024 05:30
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from 5a9988f to 8196142 Compare October 18, 2024 05:23
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

1 similar comment
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from 6b56788 to 4c325de Compare October 19, 2024 04:21
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch 2 times, most recently from 30bfbc4 to a07fe90 Compare November 4, 2024 05:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from a07fe90 to 145d49e Compare November 4, 2024 06:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2024

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@Liubov-crypto
Copy link
Collaborator

LGTM

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from 145d49e to 969b0c5 Compare November 11, 2024 05:00
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from 969b0c5 to 2da9aa6 Compare December 11, 2024 06:17
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from 2da9aa6 to 6ac115f Compare December 11, 2024 06:27
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@Liubov-crypto
Copy link
Collaborator

LGTM

@CedrikNikita CedrikNikita requested a review from alex-k8 December 16, 2024 14:24
@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from 6ac115f to 2af882d Compare December 17, 2024 05:26
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

peronczyk
peronczyk reviewed Dec 17, 2024
View reviewed changes
src/types/index.ts Outdated Show resolved Hide resolved
peronczyk
peronczyk reviewed Dec 17, 2024
View reviewed changes
src/constants/common.ts Outdated Show resolved Hide resolved
peronczyk
peronczyk reviewed Dec 17, 2024
View reviewed changes
src/constants/common.ts Outdated Show resolved Hide resolved
@CedrikNikita CedrikNikita force-pushed the feature/do-not-rely-on-sdk-to-confirm-transactions branch from 2af882d to 58ac17a Compare December 17, 2024 12:19
@github-actions GitHub Actions
Copy link

Deployed to feature-do-not-rely-on-sdk-to-confirm-transactions.wallet.z52da5wt.xyz, artifacts

@Liubov-crypto
Copy link
Collaborator

LGTM

@CedrikNikita CedrikNikita merged commit 09ff51a into develop Dec 18, 2024
6 checks passed
@CedrikNikita CedrikNikita deleted the feature/do-not-rely-on-sdk-to-confirm-transactions branch December 18, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peronczyk peronczyk peronczyk approved these changes

@alex-k8 alex-k8 Awaiting requested review from alex-k8

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate Confirmation on User's Demand, currently relies on SDK request
3 participants
@CedrikNikita @Liubov-crypto @peronczyk