Refactor/allow optional methods in base protocol adapter #2732
Conversation
martinkaintas
force-pushed
the
refactor/allow-optional-methods-in-base-protocol-adapter
branch
2 times, most recently
from
ecb3fa1 to
ef38040
Compare
CedrikNikita
force-pushed
the
feat/eth-support
branch
from
2145d14 to
1550d6a
Compare
martinkaintas
force-pushed
the
refactor/allow-optional-methods-in-base-protocol-adapter
branch
from
ef38040 to
37164eb
Compare
src/protocols/BaseProtocolAdapter.ts
Outdated
| @@ -102,32 +102,30 @@ export abstract class BaseProtocolAdapter { | |||
| */ | |||
| abstract discoverLastUsedAccountIndex(seed: Uint8Array): Promise<number>; | |||
|
|
|||
| abstract constructAndSignTx( | |||
| constructAndSignTx?( | |||
There was a problem hiding this comment.
I think this should be required for the adapters and we should align the AE adapter to use this method. What do you think @martinkaintas @CedrikNikita ?
There was a problem hiding this comment.
This is only used by the Bitcoin adapter
There was a problem hiding this comment.
Since we had a Dogecoin integration planned in future, that can be required (Dogecoin is a fork of Bitcoin).
There was a problem hiding this comment.
This is only used by the Bitcoin adapter
Yes, but maybe we should have the signing done on the adapter level? At least as a goal forced by this file.
There was a problem hiding this comment.
I don't see a clear refactoring path for this method in the AeternityAdapter
I suggest that if we really want this it should be done in a separate PR
There was a problem hiding this comment.
new task: #2773
martinkaintas
force-pushed
the
refactor/allow-optional-methods-in-base-protocol-adapter
branch
from
37164eb to
2d26435
Compare
martinkaintas
force-pushed
the
refactor/allow-optional-methods-in-base-protocol-adapter
branch
from
2d26435 to
f389042
Compare
martinkaintas
force-pushed
the
refactor/allow-optional-methods-in-base-protocol-adapter
branch
from
f389042 to
e775f40
Compare
|
In general LGTM. I have a question: why pending BTC tx is appearing in Tx list with delay? it has been showing in latest tx list immediately, but I see it in BTC account tx list with delay in 2-3 min. 2024-02-29.12.20.48.movand in recipients wallet it shows this Tx as pending in BTC acc Tx list, however it's received 11 min ago... 2024-02-29.12.34.53.mov |
martinkaintas
force-pushed
the
refactor/allow-optional-methods-in-base-protocol-adapter
branch
from
e775f40 to
32bac3a
Compare
martinkaintas
deleted the
refactor/allow-optional-methods-in-base-protocol-adapter
branch
closes #2721