Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix canary build #647

Merged
merged 17 commits into from
Mar 1, 2022
Merged

Fix canary build #647

merged 17 commits into from
Mar 1, 2022

Conversation

hellwolf
Copy link
Contributor

No description provided.

@samirsalem
Copy link

I've forked the repo and try to reproduce/fix in fork before submitting a PR

@hellwolf
Copy link
Contributor Author

thank you!

@hellwolf hellwolf mentioned this pull request Feb 23, 2022
Closed
@hellwolf
Copy link
Contributor Author

hellwolf commented Mar 1, 2022

npm/cli#3993

As you can see, using npa returns returns GIT SSH result when subpaths are passed to it. If you add a trailing "/" at the end of your path, it should fix the issue:

😡

@hellwolf hellwolf marked this pull request as ready for review March 1, 2022 10:39
@hellwolf hellwolf requested a review from a team as a code owner March 1, 2022 10:39
0xdavinchee
0xdavinchee approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hellwolf hellwolf merged commit 11064c5 into dev Mar 1, 2022
@hellwolf hellwolf deleted the fix_canary_build branch March 1, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdavinchee 0xdavinchee 0xdavinchee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hellwolf @samirsalem @0xdavinchee