Tweak names produced by package script, merge #186 into 3.10 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp) and a valid version tag. Might not work on macOS properly, because there's no readlink (install with brew/macports).
…ources() and adding more folders. Unifying the moving of tarball by using output_dir (which is currently HOME for macOS and package dir for Linux. Adding cleanup_source_dir() to remove versioned package directory. Removing unused function.
…ectory as the script is in on macOS and Linux alike.
…p() function. Revising getopts usage and defaulting to print_help in case of no input.
…ce tarball with a given ID/e-mail, when -s flag is provided.
Create assets with a script
patrickdupuis
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR merges #186 into 3.10 and also makes some naming tweaks for consistency with the package script in core.