Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug info for multi status api calls #1287

Merged
merged 10 commits into from
Mar 2, 2021
Merged

Add debug info for multi status api calls #1287

merged 10 commits into from
Mar 2, 2021

Conversation

GaboFDC
Copy link
Collaborator

@GaboFDC GaboFDC commented Mar 1, 2021 •
edited
Loading

Fixes #556

Proposed Changes

  1. Improve general debug and error messages on various cases
  2. Fix shallow fetch on deploy-dev action
  3. Add a new test. to try the built image in the context of an action, not running it locally.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@GaboFDC GaboFDC self-assigned this Mar 1, 2021
@GaboFDC GaboFDC mentioned this pull request Mar 1, 2021
Closed
3 tasks
admiralAwkbar
admiralAwkbar approved these changes Mar 2, 2021
View reviewed changes
Copy link
Collaborator

@admiralAwkbar admiralAwkbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work!

@admiralAwkbar admiralAwkbar merged commit 46df948 into master Mar 2, 2021
@admiralAwkbar admiralAwkbar deleted the gf_debug_multi_status branch March 2, 2021 14:29
This was referenced Mar 8, 2021
Closed
Merged
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 8, 2021
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Closed
Closed
bors bot referenced this pull request in bevyengine/bevy Mar 8, 2021
@dependabot
Bump github/super-linter from v3.15.1 to v3.15.2 (#1596)
2c203f7 
Bumps [github/super-linter](https://github.com/github/super-linter) from v3.15.1 to v3.15.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/super-linter/releases">github/super-linter's releases</a>.</em></p>
<blockquote>
<h2>Release v3.15.2</h2>
<h2>Changelog</h2>
<ul>
<li>Fix issue with grabbing history</li>
</ul>
<h2>Bugs</h2>
<p>we found a bad one...</p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/super-linter/commit/16f5c4067d70b7e90445a32524a96d02f973ca4b"><code>16f5c40</code></a> Updating action.yml with new release version</li>
<li><a href="https://github.com/github/super-linter/commit/68c8bf9f11fb6aba220497a4dcb30b991d46bca9"><code>68c8bf9</code></a> fix, checkout DEFAULT_BRANCH for diff base (<a href="https://github.com/github/super-linter/issues/1308">#1308</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/11720172cb14049c18cffbce4f14e4ab7c0fefe4"><code>1172017</code></a> Fix get file diff on pr event (<a href="https://github.com/github/super-linter/issues/1305">#1305</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/5294082063edae0da40593d3323bddc2285f5e2a"><code>5294082</code></a> Bump golangci/golangci-lint from v1.37.1 to v1.38.0 (<a href="https://github.com/github/super-linter/issues/1301">#1301</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/4f51c7dd0300bca3ac3e003d9b43533a24322a7d"><code>4f51c7d</code></a> Bump cljkondo/clj-kondo from 2021.02.28-alpine to 2021.03.03-alpine (<a href="https://github.com/github/super-linter/issues/1300">#1300</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/505a708ba3fd5ce46b2dfc160281231ebb826700"><code>505a708</code></a> Bump snakemake from 6.0.0 to 6.0.2 in /dependencies (<a href="https://github.com/github/super-linter/issues/1302">#1302</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/bbb3b6c4cd92fb3d4d972c43fc58f1e5b26e8ee2"><code>bbb3b6c</code></a> Bump markdownlint-cli from 0.26.0 to 0.27.1 in /dependencies (<a href="https://github.com/github/super-linter/issues/1293">#1293</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/779c472cfa48f951cacea11ba5de474a05ef9a21"><code>779c472</code></a> Bump @typescript-eslint/parser from 4.15.2 to 4.16.1 in /dependencies (<a href="https://github.com/github/super-linter/issues/1290">#1290</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/a648a4e067325b3740d168a4d82608296090100c"><code>a648a4e</code></a> Bump @typescript-eslint/eslint-plugin in /dependencies (<a href="https://github.com/github/super-linter/issues/1291">#1291</a>)</li>
<li><a href="https://github.com/github/super-linter/commit/46df94844cf76441a9e64578c934daffc7d083fc"><code>46df948</code></a> Add debug info for multi status api calls (<a href="https://github.com/github/super-linter/issues/1287">#1287</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/github/super-linter/compare/v3.15.1...16f5c4067d70b7e90445a32524a96d02f973ca4b">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>
@dependabot dependabot bot mentioned this pull request Mar 9, 2021
Closed
@aliscco aliscco mentioned this pull request Jul 31, 2022
Closed
@terrorizer1980 terrorizer1980 mentioned this pull request Jul 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admiralAwkbar admiralAwkbar admiralAwkbar approved these changes

@ferrarimarco ferrarimarco Awaiting requested review from ferrarimarco

@Hanse00 Hanse00 Awaiting requested review from Hanse00

@jwiebalk jwiebalk Awaiting requested review from jwiebalk

@nemchik nemchik Awaiting requested review from nemchik

@zkoppert zkoppert Awaiting requested review from zkoppert

Assignees

@GaboFDC GaboFDC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

multi status not working
2 participants
@GaboFDC @admiralAwkbar