fix history listener #476
Open
fix history listener #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
turns out I'm using the wrong version of history but I'll work on this so your project can work on history v5 |
|
@kale1d0code are you working on it? the peer deps change is missing: "peerDependencies": {
+ "history": "^5.0.0",
- "history": "^4.7.2",
[...]I could push it if you want me to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi amazing library can't wait to use it
however whenever I changed location my app crashed mentioning it could not find the router reducer. after some debugging I found the actions payload was malformed
it had no history action and its location was an object of the values for action and location.
looking over at the history.js project, it expects its listeners to take an object which includes location and action properties, your listener expects these values to be their own parameters.