feat: Allow infinite reconnect retries with -1 setting #574
Conversation
There was a problem hiding this comment.
I wonder how is that useful vs setting reconnection count to some large value. Because TBH I so not see how that can be safe. It is compile-time only option, so it will require some footwork to apply anyway, but I simply cannot imagine situation when you want to have really unlimited amount of retries.
|
I really want to SLEEP until I get a valid IP for the following EndpointSlice, but I thought it would be too much Kubernetes knowledge for the quirks. https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/#endpointslice-resource However, I think it would be ideal if something like a plugin function could be implemented where we could write this kind of environment-dependent code and retry logic. |
Enable supavisor to maintain connections when the database is intentionally down. This supports external systems that dynamically start and scale database instances based on supavisor metrics, allowing for "scale to zero" scenarios.
kahirokunn
force-pushed
the
infinity-retry
branch
from
40fd6e8 to
594f4b8
Compare
What kind of change does this PR introduce?
This PR introduces a feature that enables Supavisor to allow infinite reconnect retries when @reconnect_retries is set to -1.
What is the current behavior?
Currently, the reconnect logic has a hard limit. Once the number of retries exceeds @reconnect_retries, Supavisor stops attempting to reconnect if the database is unavailable.
What is the new behavior?
With this change, if @reconnect_retries is set to -1, Supavisor will never stop retrying to connect to the database.
Additional context
This supports environments that use dynamic scaling or “scale to zero” strategies where the database may be intentionally down but needs to be brought online seamlessly when connections are attempted again.
Makes “infinite” reconnection behavior a conscious user choice, helping in scenarios where the DB is scaled down and then scaled back up based on metrics.