-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: force downloading file when providing filename #195
Conversation
Pull Request Test Coverage Report for Build 3128286165Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
b3dcfa0
to
3a5d499
Compare
3a5d499
to
d3659d7
Compare
🎉 This PR is included in version 0.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks, developers, for this wonderful site. I'm wondering if the feature described here has broken recently? |
Or perhaps I didn't understand how to use the query string parameter "filename" properly. |
@inian and @fenos , I like the look of what you did to let us create a link that would download a file from github rather than showing it. I'm wondering if that feature has broken recently. Would you have time to look at my comment to this issue, at #195 (comment) |
Anyone coming here in the future: the correct parameter to add is |
Thanks @khera , I added ?download=ucd.csv to the link in the README file for this project, but still got the message |
What kind of change does this PR introduce?
feature
What is the current behavior?
we can only rely on HTML tags to download a file
What is the new behavior?
Adds a new query string parameter
filename
which if provided the file will be forced to be downloaded by the browserby adding the content-disposition header
Additional context
Closes #122