fix: consistent return types for copy (#110)

supabase · Sep 22, 2022 · d741c3d · d741c3d
1 parent 38fb1d9
commit d741c3d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/packages/StorageFileApi.ts b/src/packages/StorageFileApi.ts
@@ -228,7 +228,7 @@ export default class StorageFileApi {
     toPath: string
   ): Promise<
     | {
-        data: { message: string }
+        data: { path: string }
         error: null
       }
     | {
@@ -243,7 +243,7 @@ export default class StorageFileApi {
         { bucketId: this.bucketId, sourceKey: fromPath, destinationKey: toPath },
         { headers: this.headers }
       )
-      return { data, error: null }
+      return { data: { path: data.Key }, error: null }
     } catch (error) {
       if (isStorageError(error)) {
         return { data: null, error }

diff --git a/test/storageFileApi.test.ts b/test/storageFileApi.test.ts
@@ -122,10 +122,7 @@ describe('Object API', () => {
       const res = await storage.from(bucketName).copy(uploadPath, newPath)
 
       expect(res.error).toBeNull()
-
-      // TODO: current types are wrong, workaround for now
-      // @ts-ignore
-      expect(res.data?.Key).toEqual(`${bucketName}/${newPath}`)
+      expect(res.data?.path).toEqual(`${bucketName}/${newPath}`)
     })
 
     test('downloads an object', async () => {