Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workflow cleanup #70

Merged
merged 1 commit into from
Oct 28, 2024
Merged

chore: workflow cleanup #70

merged 1 commit into from
Oct 28, 2024

Conversation

staaldraad
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix, and maintenance to CI

What is the current behavior?

The github.event could include shell characters such as ``` in the commit message, which would be interpreted by the shell and can lead to unexpected code execution. Dependabot PRs break because of commit title rules, skip.

What is the new behavior?

Uses intermediate file for getting github.event information. Direct shell interpretation doesn't escape special characters, which can cause problems or lead to code execution. Skips the job for dependabot PRs.

@staaldraad staaldraad force-pushed the chore/workflow-cleanup branch 4 times, most recently from 86ea003 to 438a287 Compare October 8, 2024 08:17
Uses intermediate file for getting github.event information. Direct
shell interpretation doesn't escape special characters (such as `), which can cause
problems or lead to code execution. Skips the job for dependabot PRs.
@staaldraad staaldraad force-pushed the chore/workflow-cleanup branch from 438a287 to 36e8bfb Compare October 8, 2024 08:20
@J0 J0 merged commit e046a1f into main Oct 28, 2024
3 checks passed
@J0 J0 deleted the chore/workflow-cleanup branch October 28, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants