Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pg_graphql to v1.5.0 #880

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

AlexFSmirnov
Copy link
Contributor

@AlexFSmirnov AlexFSmirnov commented Feb 7, 2024

What kind of change does this PR introduce?

  • upgrade pg_graphql from v1.4.2 to v1.5.0

Additional context

Fixes a number of bugs, including field merging that was breaking pagination in Houdini GraphQL.

Action Items

  • New extension releases were Checked for any breaking changes
  • Extensions compatibility Checked
  • Backup and Restore Checked
    • Proceed to backup testing while extensions are enabled
      • After every restore, re-run the tests specified at point 3.1

Extensions compatibility testing

  1. Enable every extension
    1. Check Postgres’ log output for any error messages while doing so
      1. This might unearth incompatibilities due to unsupported internal functions, missing libraries, or missing permissions
  2. Disable every extension
    1. Check Postgres’ log output for any cleanup-related error messages
  3. Re-enable each extension
    1. Run basic tests against the features they offer, e.g.:
      1. pg_net - execute HTTP requests
      2. pg_graphql - execute queries and mutations
      3. …to be filled in

Backup Testing

Follow the testing steps steps for all the following cases:

  • Pause on new Postgres version, restore on new Postgres version
  • Pause on older Postgres version, restore on new Postgres version
  • Run a single-file backup backup, restore the backup

Testing steps

  1. Generate dummy data
    • the ‘Countries’ or ‘Slack clone’ SQL editor snippets are decent datasets to work with, albeit limited
  2. Save a db stats snapshot file
    • Do this by running supa db-stats gather -p <project_ref>
  3. Backup the database, through pausing the project, or otherwise
  4. Restore the backup, through unpausing the project or cli
  5. Check the data has been recovered successfully
    1. Visual checks/navigating through the tables works
    2. Run supa db-stats verify against the project and the previously saved file

@AlexFSmirnov AlexFSmirnov requested a review from a team as a code owner February 7, 2024 09:57
@delgado3d
Copy link
Contributor

Thanks @AlexFSmirnov. v1.5.0 was released recently, could you upgrade to that instead.

@AlexFSmirnov AlexFSmirnov changed the title chore: bump pg_graphql to v1.4.4 chore: bump pg_graphql to v1.5.0 Feb 12, 2024
@AlexFSmirnov
Copy link
Contributor Author

@delgado3d Got it ✅

@delgado3d delgado3d merged commit b44744a into supabase:develop Feb 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants