Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace customScalars with customScalarTypes #547

Conversation

nesskazu
Copy link
Contributor

@nesskazu nesskazu commented Aug 6, 2024

What kind of change does this PR introduce?

update docs.
Replace customScalars with customScalarTypes on the usage with relay page.

What is the current behavior?

Reflecting changes in relay v16.2.0

Additional context

@@ -32,7 +32,7 @@ Modify your `relay.config.js` file to reflect the following:
```

- `schemaConfig` tells the Relay compiler where to find the `nodeId` field on the `node` interface
- `customScalars` will improve Relay's type emission
- `customScalarTypes` will improve Relay's type emission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nesskazu could you please add a note that in relay versions older than v16.2.0 it should be named customScalars.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. I've added the note. 74368fc

@olirice olirice requested a review from alaister August 7, 2024 14:29
@olirice
Copy link
Contributor

olirice commented Aug 7, 2024

pinged Alaister for approval. lets wait for that before merging

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@olirice olirice merged commit 814057f into supabase:master Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants