fix: crash when V8 tries to JIT compilation in the PKU-supported environment #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyannyacha
force-pushed
the
fix-pku-jit
branch
from
fcfe54b to
d83e87b
Compare
|
@nyannyacha Thanks for the PR! will test it and merge in the next couple of days. |
laktek
approved these changes
Dec 6, 2023
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
This PR fixes the segfault when occurred the V8 tries to JIT compilation in running environments that supports PKU(Memory Protection Key; PKeys Userspace) feature.
It should only affect the environment that the PKU feature has enabled. You can check whether your environment supports the PKU feature using the below command:
Fixes #199 and might be
Resolves #200, resolves #204, resolves #207, resolves #226