Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support env loading for all string fields #3019

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 6, 2025

What kind of change does this PR introduce?

closes #3003
closes #2981
closes #2774
closes #2647

What is the new behavior?

Ensures all string fields can accept env() templates.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 6, 2025 18:56
pkg/config/config_test.go Outdated Show resolved Hide resolved
@sweatybridge sweatybridge force-pushed the env-parse branch 2 times, most recently from b88142d to ee08b0c Compare January 7, 2025 18:08
@coveralls
Copy link

coveralls commented Jan 7, 2025

Pull Request Test Coverage Report for Build 12664585526

Details

  • 75 of 97 (77.32%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.09%) to 59.599%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 75 97 77.32%
Files with Coverage Reduction New Missed Lines %
internal/storage/rm/rm.go 2 89.53%
pkg/config/config.go 3 54.06%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12645690603: 0.09%
Covered Lines: 7708
Relevant Lines: 12933

💛 - Coveralls

@sweatybridge sweatybridge merged commit 1b58c87 into develop Jan 8, 2025
8 checks passed
@sweatybridge sweatybridge deleted the env-parse branch January 8, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants