fix: secret set status code check (#355)

supabase · Aug 11, 2022 · 4da2ed0 · 4da2ed0
1 parent e927845
commit 4da2ed0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/internal/secrets/set/set.go b/internal/secrets/set/set.go
@@ -63,7 +63,8 @@ func Run(ctx context.Context, envFilePath string, args []string, fsys afero.Fs)
 			return err
 		}
 
-		if resp.StatusCode() != http.StatusOK {
+		// TODO: remove the StatusOK case after 2022-08-20
+		if resp.StatusCode() != http.StatusCreated && resp.StatusCode() != http.StatusOK {
 			return errors.New("Unexpected error setting project secrets: " + string(resp.Body))
 		}
 	}

diff --git a/internal/secrets/set/set_test.go b/internal/secrets/set/set_test.go
@@ -40,6 +40,7 @@ func TestSecretSetCommand(t *testing.T) {
 			Reply(200)
 		// Run test
 		assert.NoError(t, Run(context.Background(), "", []string{dummyEnv}, fsys))
+		assert.False(t, gock.HasUnmatchedRequest())
 	})
 
 	t.Run("Sets secret value via env file", func(t *testing.T) {
@@ -69,6 +70,7 @@ func TestSecretSetCommand(t *testing.T) {
 			Reply(200)
 		// Run test
 		assert.NoError(t, Run(context.Background(), tmpfile.Name(), []string{}, fsys))
+		assert.False(t, gock.HasUnmatchedRequest())
 	})
 
 	t.Run("throws error on missing config file", func(t *testing.T) {
@@ -148,6 +150,7 @@ func TestSecretSetCommand(t *testing.T) {
 			ReplyError(errors.New("network error"))
 		// Run test
 		assert.Error(t, Run(context.Background(), "", []string{dummyEnv}, fsys))
+		assert.False(t, gock.HasUnmatchedRequest())
 	})
 
 	t.Run("throws error on server unavailable", func(t *testing.T) {
@@ -172,5 +175,6 @@ func TestSecretSetCommand(t *testing.T) {
 			JSON(map[string]string{"message": "unavailable"})
 		// Run test
 		assert.Error(t, Run(context.Background(), "", []string{dummyEnv}, fsys))
+		assert.False(t, gock.HasUnmatchedRequest())
 	})
 }