feat: mfa (webauthn) poc #865
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 20, 2022 18:07
|
Closing as it's not too relevant now - can re-open in very near future |
|
When you planning to reopen this? Would love to see it available |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds mfa(webauthn) which is a stepping stone to passkeys
navigator.credential.createand other functionsWhat is the current behavior?
MFA(TOTP) is supported
What is the new behavior?
MFA(Webauthn) would be supported alongside MFA(TOTP) the major changes here are that
/Enrollwould take in 2 additional parameters and that/verifyand/challengewill now detect if a factor is webauthn and execute a differing code path if so.Refer to internal for more details
Would address part of #92 and allow for easier support of Passkeys once done.