feat: Add exception to handle API errors on signout #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #342 +/- ##
=======================================
Coverage 45.67% 45.68%
=======================================
Files 23 23
Lines 1898 1902 +4
=======================================
+ Hits 867 869 +2
- Misses 1031 1033 +2
☔ View full report in Codecov by Sentry. |
anand2312
reviewed
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Better exception handling on signout
What is the current behavior?
Currently if you try to sign out after a user has been deleted an API error stating
User is not foundis raised.What is the new behavior?
If you try to sign out after a user has been deleted no API error stating
User is not foundis raised, but other types of exception can still be raised.Additional context
Add any other context or screenshots.