Refactor SessionStatus #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
# Conflicts: # Postgrest/src/commonMain/kotlin/io/github/jan/supabase/postgrest/PostgrestRpc.kt # Postgrest/src/commonMain/kotlin/io/github/jan/supabase/postgrest/request/RpcRequest.kt # gradle.properties
jan-tennert
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Auth/src/commonMain/kotlin/io/github/jan/supabase/auth/status/RefreshFailureCause.kt
Fixed
Show fixed
Hide fixed
Auth/src/commonMain/kotlin/io/github/jan/supabase/auth/status/RefreshFailureCause.kt
Fixed
Show fixed
Hide fixed
Auth/src/commonMain/kotlin/io/github/jan/supabase/auth/status/SessionStatus.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature and Bug fix (closes #724)
What is the current behavior?
The session gets cleared if the refresh operation fails, no matter the cause/status code. You also cannot get the exception the refresh operation fails with in your code.
What is the new behavior?
SessionStatushas been moved to its ownstatuspackage. There have been changes to two statuses:LoadingFromStorage->InitializingNetworkError->data class RefreshFailure(cause)The cause can be one of two things:
RefreshFailureCause.NetworkError(exception: Throwable)RefreshFailureCause.InternalServerError(exception: RestException)Additional context
Add any other context or screenshots.