quote and/or escape special characters in all postrest filters #1066
+131
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...grest/src/commonMain/kotlin/io/github/jan/supabase/postgrest/query/filter/FilterOperation.kt
Fixed
Show fixed
Hide fixed
jan-tennert
approved these changes
Oct 5, 2025
jan-tennert
requested changes
Oct 5, 2025
| encodeAsList(value) | ||
| } else { | ||
| escapeValue(value) | ||
| } |
There was a problem hiding this comment.
Either a empty space for all cases or none, to keep it consistent. I'd probably say remove these empty lines, as we don't do that anywhere else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
I missed escaping characters in normal request filters
What is the new behavior?
This PR escapes those as well
Additional context
This PR changes the behavior of
filter(FilterOperation)so that it generates the proper encoding for aPairorListpassed with certainFilterOperators. I think passing either previously would have been a bug, so this shouldn't have any practical effect.