fix(pglt_workspace): emit scan errors #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteinroe
commented
Feb 24, 2025
| /// | ||
| /// Scan diagnostics are always **fatal errors**. | ||
| #[derive(Clone, Debug, Diagnostic, PartialEq)] | ||
| #[diagnostic(category = "syntax", severity = Fatal)] |
There was a problem hiding this comment.
severity = Fatal is important here -> its what we use higher up to determine whether the document can be used or not
psteinroe
commented
Feb 24, 2025
Comment on lines
+19
to
+38
| pub fn from_pg_query_err(err: pg_query::Error, input: &str) -> Vec<Self> { | ||
| let err_msg = err.to_string(); | ||
| let re = regex::Regex::new(r#"at or near "(.*?)""#).unwrap(); | ||
| let mut diagnostics = Vec::new(); | ||
|
|
||
| for captures in re.captures_iter(&err_msg) { | ||
| if let Some(matched) = captures.get(1) { | ||
| let search_term = matched.as_str(); | ||
| for (idx, _) in input.match_indices(search_term) { | ||
| let from = idx; | ||
| let to = from + search_term.len(); | ||
| diagnostics.push(ScanError { | ||
| span: Some(TextRange::new( | ||
| from.try_into().unwrap(), | ||
| to.try_into().unwrap(), | ||
| )), | ||
| message: MessageAndDescription::from(err_msg.clone()), | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
we try to find the problematic text in the input to put a range on the diagnostics. this is not safe in any way but I find it nicer to show too many diagnostics where one is for sure valid than none and have the user look through the text.
psteinroe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emitting scan errors from the lexer. we ignored them before because I thought they never happen. but they do!
also: