Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pglt_statement_splitter): alter column split #199

Merged
merged 7 commits into from
Feb 12, 2025
Merged

fix(pglt_statement_splitter): alter column split #199

merged 7 commits into from
Feb 12, 2025

Conversation

psteinroe
Copy link
Collaborator

@psteinroe psteinroe commented Feb 11, 2025 •
edited
Loading

fixes splitter for alter table alter column statements and re-enables check within rules diagnostics. we did not ignore ALTER within an ALTER statement before.

@psteinroe psteinroe changed the title fix/alter column split fix(pglt_statement_splitter): alter column split Feb 11, 2025
@psteinroe psteinroe changed the title fix(pglt_statement_splitter): alter column split fix(pglt_statement_splitter): alter column split Feb 11, 2025
juleswritescode
juleswritescode approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@juleswritescode juleswritescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic! Easy change, this means the splitter is well written :)

@psteinroe psteinroe merged commit 5ac6cff into main Feb 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juleswritescode juleswritescode juleswritescode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psteinroe @juleswritescode