tweak

changelog/137.doc.rst

@@ -0,0 +1 @@
+Added a new gallery example (:ref:`sphx_glr_generated_gallery_floating_sphere.py`) that plots a volume of points from the solar surface.

examples/floating_sphere.py

@@ -1,11 +1,12 @@
 """
 ===========================================
-Plotting A Volume from a cloud of SkyCoords
+Plotting a volume from a cloud of SkyCoords
 ===========================================
 
 This example demonstrates how to take a collection of points which you want to
-visualise as either a cloud of points or a surface.
+visualize as either a cloud of points or a surface.
 """
+
 import astropy.units as u
 import numpy as np
 import sunpy.map
@@ -17,30 +18,36 @@
 
 ################################################################################
 # Let's start by loading a map to give the visualization some context.
+
 aia = sunpy.map.Map(LOW_RES_AIA_193)
 
 ################################################################################
 # Next let's generate some point data.
+#
 # For this example we are going to generate a could which is roughly spherical.
 # We start by defining the center of our sphere.
+
 sphere_center = SkyCoord(10 * u.deg, 10 * u.deg, 1.2 * Rsun, frame="heliographic_stonyhurst")
 
 ################################################################################
 # Let's generate some spherical coordinates for theta and phi, with 50 points in
-# each coordinate.  Then we generate a sphere of radius 0.05 RSun but with some
+# each coordinate. Then we generate a sphere of radius 0.05 RSun but with some
 # random noise.
+
 theta, phi = np.mgrid[0:360:50j, -90:90:50j] * u.deg
-radius = 0.05 * Rsun + np.random.random(theta.shape) * 0.01 * Rsun
+rng = np.random.default_rng()
+radius = 0.05 * Rsun + rng.random(theta.shape) * 0.01 * Rsun
 
 ################################################################################
 # Next we use these vectors to make a SkyCoord around the defined sphere center.
+
 vectors = SphericalRepresentation(theta, phi, radius)
 new_points = sphere_center.cartesian + vectors.to_cartesian()
 point_cloud = sphere_center.frame.realize_frame(new_points)
 
 ################################################################################
 # Now we setup the pyvista visualization.
-# For the coordinate conversions to work we need to set the obstime correctly
+# For the coordinate conversions to work we need to set the ``obstime`` correctly
 # for the visualization frame.
 
 # sphinx_gallery_defer_figures
@@ -72,6 +79,7 @@
 
 ################################################################################
 # Finally set up the camera position and focus.
+
 plotter.set_camera_focus(sphere_center)
 cam_coord = SkyCoord(0 * u.deg, 0 * u.deg, 5 * Rsun, frame="heliographic_stonyhurst")
 plotter.set_camera_coordinate(cam_coord)

sunkit_pyvista/plotter.py

@@ -47,7 +47,8 @@ class SunpyPlotter:
 
     def __init__(self, *, coordinate_frame=None, obstime=None, **kwargs):
         if coordinate_frame is not None and obstime is not None:
-            raise ValueError("Only coordinate_frame or obstime can be specified, not both.")
+            msg = "Only coordinate_frame or obstime can be specified, not both."
+            raise ValueError(msg)
         if coordinate_frame is None:
             coordinate_frame = HeliocentricInertial(obstime=obstime)
         self._coordinate_frame = coordinate_frame