Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove varcheck check #849

Merged
merged 1 commit into from
Jan 10, 2024
Merged

chore: remove varcheck check #849

merged 1 commit into from
Jan 10, 2024

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Jan 10, 2024 •
edited
Loading

Description

WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.

followup #847

Related Issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (changes only affecting documentation)

Checklist

  • I have tested my changes locally and ensured they are functioning properly. Please run the make build and make test commands.
  • I have added/updated unit or e2e tests to cover my changes.
  • I have updated the relevant documentation. If you change commands or arguments, run make doc-gen to generate new documentation.

@chenrui333
chore: remove varcheck check
b8e9588 
```
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
```

Signed-off-by: Rui Chen <rui@chenrui.dev>
@the-label-bot the-label-bot bot added kind/documentation Improvements or additions to documentation size/XS size/XS labels Jan 10, 2024
@the-label-bot The Label Bot
Copy link

the-label-bot bot commented Jan 10, 2024

The Label Bot has predicted the following:

Category Value Confidence Applied Label
Kind documentation 0.799 ✔️
Size XS 0.997 ✔️

sunny0826
sunny0826 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Owner

@sunny0826 sunny0826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM, Thanks for your contribute !

@sunny0826 sunny0826 merged commit 67a171f into sunny0826:master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunny0826 sunny0826 sunny0826 approved these changes

Assignees
No one assigned
Labels
kind/documentation Improvements or additions to documentation size/XS size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @sunny0826